Commit a1ba5275 authored by Zeyi (Rice) Fan's avatar Zeyi (Rice) Fan Committed by Facebook GitHub Bot

build zstd in static to avoid DLL dependency on Windows

Summary: It seems after updating zstd to 1.4.5. `Dllexport` for zstd.dll was not being picked up correctly. Instead of having zstd being a runtime dependency let's try statically link it to avoid the DLL issue.

Reviewed By: vitaut

Differential Revision: D23970349

fbshipit-source-id: 3b14dddb64d410cb9546c416f27d73b7604b21ba
parent b29f0eb3
......@@ -23,3 +23,6 @@ subdir = zstd-1.4.5/build/cmake
# term solution for this is just to link static on macos.
[cmake.defines.os=darwin]
ZSTD_BUILD_SHARED = OFF
[cmake.defines.os=windows]
ZSTD_BUILD_SHARED = OFF
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment