Commit a6fac16f authored by Tom Jackson's avatar Tom Jackson Committed by Jordan DeLong

Remove File::tryOpen

Summary:
In hopes of keeping 'busywork' helpers out of folly, I've moved this
closer to the code that needed to do this.

Test Plan: Unit tests

Reviewed By: andrei.alexandrescu@fb.com

FB internal diff: D729194

Blame Revision: D726916
parent 9d6c66dd
...@@ -79,16 +79,6 @@ File::~File() { ...@@ -79,16 +79,6 @@ File::~File() {
return File(fd, true); return File(fd, true);
} }
/* static */ File File::tryOpen(const char* name,
int flags,
mode_t mode) {
try {
return File(name, flags, mode);
} catch (const std::system_error&) {
return File();
}
}
void File::release() { void File::release() {
fd_ = -1; fd_ = -1;
ownsFd_ = false; ownsFd_ = false;
......
...@@ -54,14 +54,6 @@ class File { ...@@ -54,14 +54,6 @@ class File {
*/ */
static File temporary(); static File temporary();
/**
* Attempts to open the file at the given path. Returns an 'closed` File
* instance on failure, which will evaluate to false.
*/
static File tryOpen(const char* name,
int flags = O_RDONLY,
mode_t mode = 0644);
/** /**
* Return the file descriptor, or -1 if the file was closed. * Return the file descriptor, or -1 if the file was closed.
*/ */
......
...@@ -122,8 +122,3 @@ TEST(File, Truthy) { ...@@ -122,8 +122,3 @@ TEST(File, Truthy) {
EXPECT_TRUE(false); EXPECT_TRUE(false);
} }
} }
TEST(File, TryOpen) {
EXPECT_FALSE(!!File::tryOpen("does_not_exist.txt"));
EXPECT_TRUE(!!File::tryOpen("/etc/fstab"));
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment