Commit b646e5df authored by Lucas Dobson-Defenbaugh's avatar Lucas Dobson-Defenbaugh Committed by Facebook GitHub Bot

Fix deprecation warnings for collectXSemiFuture

Summary:
We're recommending collectAny as a replacement for
collectAllSemiFutures :(

Reviewed By: LeeHowes

Differential Revision: D21197163

fbshipit-source-id: 0055e0feb5cc74a767370bc1dc9fe8e4d8dffcfc
parent 43b0911a
...@@ -1604,7 +1604,7 @@ SemiFuture<std::tuple<typename remove_cvref_t<Fs>::value_type...>> collect( ...@@ -1604,7 +1604,7 @@ SemiFuture<std::tuple<typename remove_cvref_t<Fs>::value_type...>> collect(
} }
template <typename... Fs> template <typename... Fs>
[[deprecated("collectSemiFuture is deprecated and identical to plain collect. Please use collectAny instead.")]] SemiFuture< [[deprecated("collectSemiFuture is deprecated and identical to plain collect. Please use collect instead.")]] SemiFuture<
std::tuple<typename remove_cvref_t<Fs>::value_type...>> std::tuple<typename remove_cvref_t<Fs>::value_type...>>
collectSemiFuture(Fs&&... fs) { collectSemiFuture(Fs&&... fs) {
return collect(std::forward<Fs>(fs)...); return collect(std::forward<Fs>(fs)...);
...@@ -1618,7 +1618,7 @@ Future<std::tuple<typename remove_cvref_t<Fs>::value_type...>> collectUnsafe( ...@@ -1618,7 +1618,7 @@ Future<std::tuple<typename remove_cvref_t<Fs>::value_type...>> collectUnsafe(
template <class Collection> template <class Collection>
[[deprecated( [[deprecated(
"collectSemiFuture is deprecated and identical to plain collect. Please use collectAny instead.")]] auto "collectSemiFuture is deprecated and identical to plain collect. Please use collect instead.")]] auto
collectSemiFuture(Collection&& c) collectSemiFuture(Collection&& c)
-> decltype(collectSemiFuture(c.begin(), c.end())) { -> decltype(collectSemiFuture(c.begin(), c.end())) {
return collectSemiFuture(c.begin(), c.end()); return collectSemiFuture(c.begin(), c.end());
......
...@@ -2414,7 +2414,7 @@ auto collectAll(Collection&& c) -> decltype(collectAll(c.begin(), c.end())) { ...@@ -2414,7 +2414,7 @@ auto collectAll(Collection&& c) -> decltype(collectAll(c.begin(), c.end())) {
/// is a SemiFuture<std::tuple<Try<T1>, Try<T2>, ...>>. /// is a SemiFuture<std::tuple<Try<T1>, Try<T2>, ...>>.
/// The Futures are moved in, so your copies are invalid. /// The Futures are moved in, so your copies are invalid.
template <typename... Fs> template <typename... Fs>
[[deprecated("collectAllSemiFuture is deprecated and identical to plain collectAll. Please use collectAny instead.")]] SemiFuture< [[deprecated("collectAllSemiFuture is deprecated and identical to plain collectAll. Please use collectAll instead.")]] SemiFuture<
std::tuple<Try<typename remove_cvref_t<Fs>::value_type>...>> std::tuple<Try<typename remove_cvref_t<Fs>::value_type>...>>
collectAllSemiFuture(Fs&&... fs); collectAllSemiFuture(Fs&&... fs);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment