Commit c9cbfdb7 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Revert D4618623: Give observer manager threads a name

Summary: This reverts commit 21b86944f513da0700039a3e3736937fd72e8887

Differential Revision: D4618623

fbshipit-source-id: 6ab6498a2ce22895d7052e258d1af216d46ca178
parent feff1cde
...@@ -16,11 +16,8 @@ ...@@ -16,11 +16,8 @@
#include <folly/experimental/observer/detail/ObserverManager.h> #include <folly/experimental/observer/detail/ObserverManager.h>
#include <folly/ExceptionString.h> #include <folly/ExceptionString.h>
#include <folly/FixedString.h>
#include <folly/Format.h>
#include <folly/MPMCQueue.h> #include <folly/MPMCQueue.h>
#include <folly/Singleton.h> #include <folly/Singleton.h>
#include <folly/ThreadName.h>
#include <folly/portability/GFlags.h> #include <folly/portability/GFlags.h>
namespace folly { namespace folly {
...@@ -35,9 +32,6 @@ DEFINE_int32( ...@@ -35,9 +32,6 @@ DEFINE_int32(
4, 4,
"How many internal threads ObserverManager should use"); "How many internal threads ObserverManager should use");
static constexpr auto kObserverManagerThreadNamePrefix =
folly::makeFixedString("ObserverMngr");
namespace { namespace {
constexpr size_t kCurrentQueueSize{10 * 1024}; constexpr size_t kCurrentQueueSize{10 * 1024};
constexpr size_t kNextQueueSize{10 * 1024}; constexpr size_t kNextQueueSize{10 * 1024};
...@@ -51,9 +45,7 @@ class ObserverManager::CurrentQueue { ...@@ -51,9 +45,7 @@ class ObserverManager::CurrentQueue {
FLAGS_observer_manager_pool_size = 1; FLAGS_observer_manager_pool_size = 1;
} }
for (int32_t i = 0; i < FLAGS_observer_manager_pool_size; ++i) { for (int32_t i = 0; i < FLAGS_observer_manager_pool_size; ++i) {
threads_.emplace_back([this, i]() { threads_.emplace_back([&]() {
folly::setThreadName(
folly::sformat("{}{}", kObserverManagerThreadNamePrefix, i));
ObserverManager::inManagerThread_ = true; ObserverManager::inManagerThread_ = true;
while (true) { while (true) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment