Commit d51aa234 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Re-enable a couple of tests under MSVC

Summary: VS 2017 is here and the bugs these were hitting have been fixed, so re-enable them.

Reviewed By: yfeldblum

Differential Revision: D4742829

fbshipit-source-id: 898e7cfea9de9ffa813c562c12e0e18e0577c8c3
parent 3ffa8cf0
......@@ -1112,14 +1112,10 @@ TEST(RangeFunc, Array) {
testRangeFunc(x, 3);
}
// MSVC doesn't like it when you try to std::move C arrays:
// https://developercommunity.visualstudio.com/content/problem/2441/
#ifndef _MSC_VER
TEST(RangeFunc, CArray) {
int x[] {1, 2, 3, 4};
testRangeFunc(x, 4);
}
#endif
TEST(RangeFunc, ConstexprCArray) {
static constexpr const int numArray[4] = {3, 17, 1, 9};
......@@ -1133,15 +1129,8 @@ TEST(RangeFunc, ConstexprStdArray) {
static constexpr const std::array<int, 4> numArray = {{3, 17, 1, 9}};
constexpr const auto numArrayRange = range(numArray);
EXPECT_EQ(17, numArrayRange[1]);
// MSVC 2017 RC and earlier have an issue that causes the beginning and
// end of numArrayRange to point to different copies of numArray, causing
// this attempt to calculate the size to error at compile time because
// they don't point to parts of the same array :(
// https://developercommunity.visualstudio.com/content/problem/3216/
#if !defined(_MSC_VER) || _MSC_VER > 191024629
constexpr const auto numArrayRangeSize = numArrayRange.size();
EXPECT_EQ(4, numArrayRangeSize);
#endif
}
TEST(RangeFunc, ConstexprStdArrayZero) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment