minor tweaks to utils.py
Summary: Update `make_temp_dir()` to use `shutil.rmtree()` to clean up rather than just `os.rmdir()`. If the function using this context manager throws it may leave behind files inside the temporary directory, and it is useful to always clean those up. Also update `read_fbcode_builder_config()` to work regardless of the current working directory. Previously this function only worked if the current working directory was the directory containing the configuration file. This makes sure that `read_fbcode_builder_config()` calls are always treated as relative to the directory containing the configuration file being read. Reviewed By: yfeldblum Differential Revision: D7597743 fbshipit-source-id: 817063104081336fcc0a9f825beb74d7d4377499
Showing
Please register or sign in to comment