Commit d69f6a7a authored by Yedidya Feldblum's avatar Yedidya Feldblum Committed by facebook-github-bot-9

Simplify some checks by using __CLANG_PREREQ

Summary: [Folly] Simplify some checks by using `__CLANG_PREREQ`.

Reviewed By: meyering

Differential Revision: D2657979

fb-gh-sync-id: 80ff56bbab0e78465d71315b729ad14a09706ed5
parent 95ccc564
...@@ -473,11 +473,9 @@ TEST(Optional, MakeOptional) { ...@@ -473,11 +473,9 @@ TEST(Optional, MakeOptional) {
EXPECT_EQ(**optIntPtr, 3); EXPECT_EQ(**optIntPtr, 3);
} }
#ifdef __clang__ #if __CLANG_PREREQ(3, 6)
# pragma clang diagnostic push # pragma clang diagnostic push
# if __clang_major__ > 3 || __clang_minor__ >= 6 # pragma clang diagnostic ignored "-Wself-move"
# pragma clang diagnostic ignored "-Wself-move"
# endif
#endif #endif
TEST(Optional, SelfAssignment) { TEST(Optional, SelfAssignment) {
...@@ -490,8 +488,8 @@ TEST(Optional, SelfAssignment) { ...@@ -490,8 +488,8 @@ TEST(Optional, SelfAssignment) {
ASSERT_TRUE(b.hasValue() && b.value() == 23333333); ASSERT_TRUE(b.hasValue() && b.value() == 23333333);
} }
#ifdef __clang__ #if __CLANG_PREREQ(3, 6)
#pragma clang diagnostic pop # pragma clang diagnostic pop
#endif #endif
class ContainsOptional { class ContainsOptional {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment