Commit d9f6a3fd authored by Joe Loser's avatar Joe Loser Committed by Facebook Github Bot

Cut endian members from fbstring_core (#1117)

Summary:
- `fbstring_core` defines constants based on the host endianness.
- This is purely duplicated as these constants live in `Portability.h`.
  As such, remove them from `fbstring_core` class.
Pull Request resolved: https://github.com/facebook/folly/pull/1117

Reviewed By: Orvid

Differential Revision: D15096910

Pulled By: yfeldblum

fbshipit-source-id: ff4e828dfd1b19daeedf48bbf1719a3fd72c0843
parent b7283ea0
...@@ -292,18 +292,6 @@ class fbstring_core_model { ...@@ -292,18 +292,6 @@ class fbstring_core_model {
*/ */
template <class Char> template <class Char>
class fbstring_core { class fbstring_core {
protected:
// It's MSVC, so we just have to guess ... and allow an override
#ifdef _MSC_VER
#ifdef FOLLY_ENDIAN_BE
static constexpr auto kIsLittleEndian = false;
#else
static constexpr auto kIsLittleEndian = true;
#endif
#else
static constexpr auto kIsLittleEndian =
__BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__;
#endif
public: public:
fbstring_core() noexcept { fbstring_core() noexcept {
reset(); reset();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment