Commit eb8b2d91 authored by Christopher Dykes's avatar Christopher Dykes Committed by Facebook Github Bot

Actually allow SFINAE to occur with setThreadName

Summary:
It wasn't actually SFINAE the way it was setup previously, which meant it was just a hard error under MSVC.
Whoops.

Reviewed By: yfeldblum

Differential Revision: D4453702

fbshipit-source-id: 5be600fb5ecdc8255795fefbd37c1fe26e7266dd
parent b1974960
...@@ -22,6 +22,7 @@ ...@@ -22,6 +22,7 @@
#include <pthread.h> #include <pthread.h>
#include <folly/Range.h> #include <folly/Range.h>
#include <folly/Traits.h>
namespace folly { namespace folly {
...@@ -70,11 +71,10 @@ inline bool setThreadName(pthread_t id, StringPiece name) { ...@@ -70,11 +71,10 @@ inline bool setThreadName(pthread_t id, StringPiece name) {
} }
#endif #endif
template <> template <
inline typename std::enable_if< typename = folly::_t<std::enable_if<
std::is_same<pthread_t, std::thread::native_handle_type>::value, std::is_same<pthread_t, std::thread::native_handle_type>::value>>>
bool>::type inline bool setThreadName(std::thread::id id, StringPiece name) {
setThreadName(std::thread::id id, StringPiece name) {
static_assert( static_assert(
sizeof(std::thread::native_handle_type) == sizeof(decltype(id)), sizeof(std::thread::native_handle_type) == sizeof(decltype(id)),
"This assumes std::thread::id is a thin wrapper around " "This assumes std::thread::id is a thin wrapper around "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment