Commit f6ca07e8 authored by Dan Melnic's avatar Dan Melnic Committed by Facebook Github Bot

Add missing switch case

Summary: Add missing switch case

Reviewed By: yfeldblum

Differential Revision: D17945170

fbshipit-source-id: 8128c40e1c86b2a5ff8d1bad3c0e9fe197adc174
parent a9e811bd
...@@ -335,6 +335,7 @@ class BenchmarkResultsPrinter { ...@@ -335,6 +335,7 @@ class BenchmarkResultsPrinter {
int(name.length()), int(name.length()),
metricReadable(ptr->value, 2).c_str()); metricReadable(ptr->value, 2).c_str());
break; break;
case UserMetric::Type::CUSTOM:
default: default:
printf(" %-*d", int(name.length()), ptr->value); printf(" %-*d", int(name.length()), ptr->value);
} }
......
...@@ -775,6 +775,7 @@ toAppend( ...@@ -775,6 +775,7 @@ toAppend(
case DoubleToStringConverter::FIXED: case DoubleToStringConverter::FIXED:
conv.ToFixed(value, int(numDigits), &builder); conv.ToFixed(value, int(numDigits), &builder);
break; break;
case DoubleToStringConverter::PRECISION:
default: default:
assert(mode == DoubleToStringConverter::PRECISION); assert(mode == DoubleToStringConverter::PRECISION);
conv.ToPrecision(value, int(numDigits), &builder); conv.ToPrecision(value, int(numDigits), &builder);
......
...@@ -213,6 +213,7 @@ struct ExpectedStorage { ...@@ -213,6 +213,7 @@ struct ExpectedStorage {
case Which::eError: case Which::eError:
this->assignError(static_cast<Other&&>(that).error()); this->assignError(static_cast<Other&&>(that).error());
break; break;
case Which::eEmpty:
default: default:
this->clear(); this->clear();
break; break;
...@@ -407,6 +408,7 @@ struct ExpectedStorage<Value, Error, StorageType::eUnion> ...@@ -407,6 +408,7 @@ struct ExpectedStorage<Value, Error, StorageType::eUnion>
case Which::eError: case Which::eError:
this->error().~Error(); this->error().~Error();
break; break;
case Which::eEmpty:
default: default:
break; break;
} }
...@@ -457,6 +459,7 @@ struct ExpectedStorage<Value, Error, StorageType::eUnion> ...@@ -457,6 +459,7 @@ struct ExpectedStorage<Value, Error, StorageType::eUnion>
case Which::eError: case Which::eError:
this->assignError(static_cast<Other&&>(that).error()); this->assignError(static_cast<Other&&>(that).error());
break; break;
case Which::eEmpty:
default: default:
this->clear(); this->clear();
break; break;
...@@ -508,6 +511,7 @@ struct ExpectedStorage<Value, Error, StorageType::ePODStruct> { ...@@ -508,6 +511,7 @@ struct ExpectedStorage<Value, Error, StorageType::ePODStruct> {
case Which::eError: case Which::eError:
this->assignError(static_cast<Other&&>(that).error()); this->assignError(static_cast<Other&&>(that).error());
break; break;
case Which::eEmpty:
default: default:
this->clear(); this->clear();
break; break;
......
...@@ -476,6 +476,7 @@ class fbstring_core { ...@@ -476,6 +476,7 @@ class fbstring_core {
return ml_.size_; return ml_.size_;
} }
break; break;
case Category::isMedium:
default: default:
break; break;
} }
......
...@@ -339,6 +339,7 @@ void formatString(StringPiece val, FormatArg& arg, FormatCallback& cb) { ...@@ -339,6 +339,7 @@ void formatString(StringPiece val, FormatArg& arg, FormatCallback& cb) {
case FormatArg::Align::PAD_AFTER_SIGN: case FormatArg::Align::PAD_AFTER_SIGN:
pad(padChars); pad(padChars);
break; break;
case FormatArg::Align::INVALID:
default: default:
abort(); abort();
break; break;
...@@ -463,6 +464,9 @@ class FormatValue< ...@@ -463,6 +464,9 @@ class FormatValue<
case FormatArg::Sign::SPACE_OR_MINUS: case FormatArg::Sign::SPACE_OR_MINUS:
sign = ' '; sign = ' ';
break; break;
case FormatArg::Sign::DEFAULT:
case FormatArg::Sign::MINUS:
case FormatArg::Sign::INVALID:
default: default:
sign = '\0'; sign = '\0';
break; break;
......
...@@ -134,6 +134,9 @@ void FormatValue<double>::formatHelper( ...@@ -134,6 +134,9 @@ void FormatValue<double>::formatHelper(
case FormatArg::Sign::SPACE_OR_MINUS: case FormatArg::Sign::SPACE_OR_MINUS:
plusSign = ' '; plusSign = ' ';
break; break;
case FormatArg::Sign::DEFAULT:
case FormatArg::Sign::MINUS:
case FormatArg::Sign::INVALID:
default: default:
plusSign = '\0'; plusSign = '\0';
break; break;
......
...@@ -121,6 +121,8 @@ CIDRNetwork IPAddress::createNetwork( ...@@ -121,6 +121,8 @@ CIDRNetwork IPAddress::createNetwork(
vec.size() == 2 ? vec.at(1) : to<string>(cidr), vec.size() == 2 ? vec.at(1) : to<string>(cidr),
subnet.bitCount())); subnet.bitCount()));
} }
case CIDRNetworkError::INVALID_DEFAULT_CIDR:
case CIDRNetworkError::INVALID_IP_SLASH_CIDR:
default: default:
// unreachable // unreachable
break; break;
......
...@@ -168,6 +168,7 @@ void Try<T>::throwIfFailed() const { ...@@ -168,6 +168,7 @@ void Try<T>::throwIfFailed() const {
return; return;
case Contains::EXCEPTION: case Contains::EXCEPTION:
e_.throw_exception(); e_.throw_exception();
case Contains::NOTHING:
default: default:
throw_exception<UsingUninitializedTry>(); throw_exception<UsingUninitializedTry>();
} }
......
...@@ -1323,6 +1323,15 @@ static lzma_ret lzmaThrowOnError(lzma_ret const rc) { ...@@ -1323,6 +1323,15 @@ static lzma_ret lzmaThrowOnError(lzma_ret const rc) {
case LZMA_STREAM_END: case LZMA_STREAM_END:
case LZMA_BUF_ERROR: // not fatal: returned if no progress was made twice case LZMA_BUF_ERROR: // not fatal: returned if no progress was made twice
return rc; return rc;
case LZMA_NO_CHECK:
case LZMA_UNSUPPORTED_CHECK:
case LZMA_GET_CHECK:
case LZMA_MEM_ERROR:
case LZMA_MEMLIMIT_ERROR:
case LZMA_FORMAT_ERROR:
case LZMA_OPTIONS_ERROR:
case LZMA_DATA_ERROR:
case LZMA_PROG_ERROR:
default: default:
throw std::runtime_error( throw std::runtime_error(
to<std::string>("LZMA2StreamCodec: error: ", rc)); to<std::string>("LZMA2StreamCodec: error: ", rc));
......
...@@ -1032,6 +1032,9 @@ T dynamic::asImpl() const { ...@@ -1032,6 +1032,9 @@ T dynamic::asImpl() const {
return to<T>(*get_nothrow<bool>()); return to<T>(*get_nothrow<bool>());
case STRING: case STRING:
return to<T>(*get_nothrow<std::string>()); return to<T>(*get_nothrow<std::string>());
case NULLT:
case ARRAY:
case OBJECT:
default: default:
throw_exception<TypeError>("int/double/bool/string", type()); throw_exception<TypeError>("int/double/bool/string", type());
} }
......
...@@ -462,6 +462,7 @@ const dynamic* dynamic::get_ptr(json_pointer const& jsonPtr) const& { ...@@ -462,6 +462,7 @@ const dynamic* dynamic::get_ptr(json_pointer const& jsonPtr) const& {
throw_exception<TypeError>("object/array", objType); throw_exception<TypeError>("object/array", objType);
case err_code::json_pointer_out_of_bounds: case err_code::json_pointer_out_of_bounds:
return nullptr; return nullptr;
case err_code::other:
default: default:
return nullptr; return nullptr;
} }
......
...@@ -46,6 +46,15 @@ static int64_t decodeInt(Cursor& curs) { ...@@ -46,6 +46,15 @@ static int64_t decodeInt(Cursor& curs) {
return curs.read<int32_t>(); return curs.read<int32_t>();
case BserType::Int64: case BserType::Int64:
return curs.read<int64_t>(); return curs.read<int64_t>();
case BserType::Array:
case BserType::Object:
case BserType::String:
case BserType::Real:
case BserType::True:
case BserType::False:
case BserType::Null:
case BserType::Template:
case BserType::Skip:
default: default:
throwDecodeError( throwDecodeError(
curs, "invalid integer encoding detected (", (int8_t)enc, ")"); curs, "invalid integer encoding detected (", (int8_t)enc, ")");
...@@ -192,6 +201,15 @@ static size_t decodeHeader(Cursor& curs) { ...@@ -192,6 +201,15 @@ static size_t decodeHeader(Cursor& curs) {
case BserType::Int64: case BserType::Int64:
int_size = 8; int_size = 8;
break; break;
case BserType::Array:
case BserType::Object:
case BserType::String:
case BserType::Real:
case BserType::True:
case BserType::False:
case BserType::Null:
case BserType::Template:
case BserType::Skip:
default: default:
int_size = 0; int_size = 0;
} }
......
...@@ -650,7 +650,10 @@ class Core final { ...@@ -650,7 +650,10 @@ class Core final {
case State::OnlyCallbackAllowInline: case State::OnlyCallbackAllowInline:
proxyCallback(state); proxyCallback(state);
break; break;
case State::OnlyResult:
case State::Proxy:
case State::Done:
case State::Empty:
default: default:
terminate_with<std::logic_error>("setCallback unexpected state"); terminate_with<std::logic_error>("setCallback unexpected state");
} }
...@@ -705,7 +708,10 @@ class Core final { ...@@ -705,7 +708,10 @@ class Core final {
state_.store(State::Done, std::memory_order_relaxed); state_.store(State::Done, std::memory_order_relaxed);
doCallback(std::move(completingKA), state); doCallback(std::move(completingKA), state);
return; return;
case State::OnlyResult:
case State::Proxy:
case State::Done:
case State::Empty:
default: default:
terminate_with<std::logic_error>("setResult unexpected state"); terminate_with<std::logic_error>("setResult unexpected state");
} }
...@@ -846,6 +852,9 @@ class Core final { ...@@ -846,6 +852,9 @@ class Core final {
case State::Empty: case State::Empty:
break; break;
case State::Start:
case State::OnlyCallback:
case State::OnlyCallbackAllowInline:
default: default:
terminate_with<std::logic_error>("~Core unexpected state"); terminate_with<std::logic_error>("~Core unexpected state");
} }
......
...@@ -53,6 +53,7 @@ SSLContext::SSLContext(SSLVersion version) { ...@@ -53,6 +53,7 @@ SSLContext::SSLContext(SSLVersion version) {
opt = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_TLSv1 | opt = SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3 | SSL_OP_NO_TLSv1 |
SSL_OP_NO_TLSv1_1; SSL_OP_NO_TLSv1_1;
break; break;
case SSLv2:
default: default:
// do nothing // do nothing
break; break;
...@@ -185,7 +186,7 @@ int SSLContext::getVerificationMode( ...@@ -185,7 +186,7 @@ int SSLContext::getVerificationMode(
case SSLVerifyPeerEnum::NO_VERIFY: case SSLVerifyPeerEnum::NO_VERIFY:
mode = SSL_VERIFY_NONE; mode = SSL_VERIFY_NONE;
break; break;
case SSLVerifyPeerEnum::USE_CTX:
default: default:
break; break;
} }
......
...@@ -94,6 +94,10 @@ AsyncSocketException::AsyncSocketExceptionType exTypefromSSLErr(SSLError err) { ...@@ -94,6 +94,10 @@ AsyncSocketException::AsyncSocketExceptionType exTypefromSSLErr(SSLError err) {
return AsyncSocketException::END_OF_FILE; return AsyncSocketException::END_OF_FILE;
case SSLError::NETWORK_ERROR: case SSLError::NETWORK_ERROR:
return AsyncSocketException::NETWORK_ERROR; return AsyncSocketException::NETWORK_ERROR;
case SSLError::CLIENT_RENEGOTIATION:
case SSLError::INVALID_RENEGOTIATION:
case SSLError::EARLY_WRITE:
case SSLError::SSL_ERROR:
default: default:
// everything else is a SSL_ERROR // everything else is a SSL_ERROR
return AsyncSocketException::SSL_ERROR; return AsyncSocketException::SSL_ERROR;
......
...@@ -221,6 +221,12 @@ do_add( ...@@ -221,6 +221,12 @@ do_add(
ptr.error().context->push_back(value); ptr.error().context->push_back(value);
break; break;
} }
case res_err_code::other:
case res_err_code::index_out_of_bounds:
case res_err_code::index_not_numeric:
case res_err_code::index_has_leading_zero:
case res_err_code::element_not_object_or_array:
case res_err_code::json_pointer_out_of_bounds:
default: default:
return folly::makeUnexpected(app_err_code::other); return folly::makeUnexpected(app_err_code::other);
} }
......
...@@ -28,6 +28,10 @@ inline std::memory_order default_failure_memory_order( ...@@ -28,6 +28,10 @@ inline std::memory_order default_failure_memory_order(
return std::memory_order_acquire; return std::memory_order_acquire;
case std::memory_order_release: case std::memory_order_release:
return std::memory_order_relaxed; return std::memory_order_relaxed;
case std::memory_order_relaxed:
case std::memory_order_consume:
case std::memory_order_acquire:
case std::memory_order_seq_cst:
default: default:
return successMode; return successMode;
} }
......
...@@ -877,6 +877,7 @@ TEST(IPAddress, V6Types) { ...@@ -877,6 +877,7 @@ TEST(IPAddress, V6Types) {
return "teredo"; return "teredo";
case IPAddressV6::Type::T6TO4: case IPAddressV6::Type::T6TO4:
return "6to4"; return "6to4";
case IPAddressV6::Type::NORMAL:
default: default:
return "default"; return "default";
} }
......
...@@ -90,6 +90,10 @@ bool compareDynamicWithNestedJson( ...@@ -90,6 +90,10 @@ bool compareDynamicWithNestedJson(
} }
} }
return false; return false;
case dynamic::Type::NULLT:
case dynamic::Type::BOOL:
case dynamic::Type::DOUBLE:
case dynamic::Type::INT64:
default: default:
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment