Commit ff76c329 authored by Yuri Putivsky's avatar Yuri Putivsky Committed by Facebook Github Bot 0

takeOwnershipOfPipes method releases memory

Summary: takeOwnershipOfPipes should left zero heap memory allocated in folly:Subprocess class instance.

Reviewed By: snarkmaster

Differential Revision: D3638503

fbshipit-source-id: aac7b10bd7399c44868f32c01164f4123892598f
parent 38237272
......@@ -832,7 +832,8 @@ std::vector<Subprocess::ChildPipe> Subprocess::takeOwnershipOfPipes() {
for (auto& p : pipes_) {
pipes.emplace_back(p.childFd, std::move(p.pipe));
}
pipes_.clear();
// release memory
std::vector<Pipe>().swap(pipes_);
return pipes;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment