1. 25 Oct, 2018 2 commits
    • Yedidya Feldblum's avatar
      Add bidi support to IteratorFacade · 03784170
      Yedidya Feldblum authored
      Summary: [Folly] Add bidi support to IteratorFacade
      
      Reviewed By: aary
      
      Differential Revision: D10477733
      
      fbshipit-source-id: 6779580a4fdea88d29fb51454da04c9605b026bb
      03784170
    • Lee Howes's avatar
      Remove nullary continuation form of then · 611dae9a
      Lee Howes authored
      Summary:
      Remove the form of Future::then that could take a continuation with no parameters, to force consistent use of parameters.
      
      This form was already deprecated.
      
      Reviewed By: Orvid
      
      Differential Revision: D10219141
      
      fbshipit-source-id: 4f8bdeaf617d8e78a5c85aa1374f6a0d38d63da9
      611dae9a
  2. 24 Oct, 2018 6 commits
    • Adam Simpkins's avatar
      cmake: compile with -std=gnu++1z by default · dacf5bc6
      Adam Simpkins authored
      Summary:
      Switch from `-std=gnu++14` to `-std=gnu++1z`
      
      This is required in order to allow downstream projects that use folly to build
      with `-std=gnu++1z`.  The linkage for how constexpr variables are emitted
      has changed between `gnu++14` and `gnu++1z`.  If folly is compiled with
      `gnu++14` but downstream dependencies try to build with `gnu++1z` they will
      get link errors (multiple definitions) for constexpr variables defined in
      folly header files.
      
      The reverse (compiling folly with `gnu++1z` but downstream projects with
      `gnu++14`) does not seem to cause any problems.  Nonetheless, I have provided
      `CXX_STD` as a CMake option so that users can override this setting if it does
      cause any problems for some reason.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10448691
      
      fbshipit-source-id: c44f568a7ff175c432865badeaaa9b3ebbaf8987
      dacf5bc6
    • HC Zhu's avatar
      more test cases for folly::split with std::ignore · 92d74b9b
      HC Zhu authored
      Summary: Simply the code a little bit.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10609398
      
      fbshipit-source-id: 055f6fd7fb9f5768df7b0b2b28071fa53181a838
      92d74b9b
    • Lewis Baker's avatar
      Declare folly::SpinLock methods as noexcept · a917f122
      Lewis Baker authored
      Summary:
      Declare folly::SpinLock constructor and methods as noexcept so that types that have a compiler-generated default-constructor (like folly::Synchronized) get a noexcept default constructor.
      
      Also declare methods on folly::MicroSpinLock and folly::detail::Sleeper as noexcept.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10518727
      
      fbshipit-source-id: 8582fd8b3893ad25ef736bd7a63465872ebe67af
      a917f122
    • Lewis Baker's avatar
      Refactor folly::coro::Task to eliminate unnecessary synchronisation · 0d49d8d4
      Lewis Baker authored
      Summary:
      This ability to eagerly start a folly::coro::Task by calling .scheduleVia() introduced a potential race between the operation completing concurrently on another thread and the current thread then subsequently co_awaiting the returned folly::coro::Future.
      
      Thus the implementation of coro::Task's promise_type required the use of an atomic variable to decide this race.
      
      This diff eliminates the need for that synchronisation by separating the step of associating the task with an executor from the step of launching the task so that the Task is always lazily started.
      
      The folly::coro::Task<T>::scheduleVia() method has now been replaced with a .scheduleOn() method that returns a folly::coro::TaskWithExecutor<T>. The TaskWithExecutor<T> type is awaitable and will schedule the Task's execution on the bound executor when it is awaited.
      
      Also fixes a cyclic dependency issue between Promise.h and Task.h/Future.h by merging them all into Task.h.
      
      folly/futures/Future.h now defines the `folly::coro::toSemiFuture()` function for wrapping an Awaitable up into a `folly::SemiFuture<T>`. The `folly::coro::Future<T>` type and folly/experimental/coro/Future.h header has been removed.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D9948564
      
      fbshipit-source-id: 21c9ee1ec0e67d56321629b5901c3eb7cddcfe9b
      0d49d8d4
    • Cornel Rat's avatar
      Use F14 for the RequestToken cache · 3020a18c
      Cornel Rat authored
      Summary: Looks like switching to F14 speeds up RequestToken creation by ~25% in some projects.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10518982
      
      fbshipit-source-id: bf924a0a86f940f7ed36526ca6eda4fe1421f5f8
      3020a18c
    • Wez Furlong's avatar
      cmake in a _build subdir to fix macos build · c227ceae
      Wez Furlong authored
      Summary:
      This addresses a hilarious but hard to trace build problem on
      macOS.  The issue is that the build manages to resolve `folly/String.h`
      in place of `string.h` and breaks compilation of `<cstring>` and all
      that include it.
      
      The resolution is to ensure that we generate a subdir for the cmake
      build.
      
      Reviewed By: simpkins
      
      Differential Revision: D10520960
      
      fbshipit-source-id: 9bebeda69c6e28ebca146f9b96ee01bedd2d6ef1
      c227ceae
  3. 23 Oct, 2018 1 commit
    • Nathan Bronson's avatar
      checkedMalloc/free substitutes that performs sized deallocation · 9ae803c7
      Nathan Bronson authored
      Summary:
      Sized deallocation makes it faster for jemalloc to locate an
      allocation's metadata.  Accessing this functionality via ::operator
      delete(void*,size_t) is both portable and a bit more direct than
      calling sdallocx after a dynamic jemalloc check.  This diff adds small
      functions allocateBytes and deallocateBytes that are replacements
      for folly::checkedMalloc and free (and should be paired), to localize
      the #ifdef.
      
      Reviewed By: marksantaniello
      
      Differential Revision: D10496934
      
      fbshipit-source-id: eb193e1c315ca88286126f5eb68c705301ad5177
      9ae803c7
  4. 22 Oct, 2018 5 commits
    • Maged Michael's avatar
      Remove obsolete version of hazard pointers under folly/experimental · aee5ab34
      Maged Michael authored
      Summary:
      Remove obsolete version of hazard pointers under folly/experimental.
      Current version is under folly/synchronization.
      
      Reviewed By: djwatson
      
      Differential Revision: D10441558
      
      fbshipit-source-id: 36ef42f83a857ce4bdfff8b64cf9dcc179e0c804
      aee5ab34
    • Adam Simpkins's avatar
      cmake: always include files from the source directory first · 3bd7d93d
      Adam Simpkins authored
      Summary:
      Add the current source and build directories to the very front of the include
      directory list.  This ensures that folly finds its own local headers first,
      even if the install directory already contains an older version of the folly
      headers.
      
      Even though the install directory was appended to the include list after the
      current source directory in this statement, it could have ended up already in
      the include list if other dependencies (e.g., glog or gmock) were found in
      that directory.
      
      Reviewed By: Orvid
      
      Differential Revision: D10448692
      
      fbshipit-source-id: 539613a055db41d6115f8d04c5f6fa90841a414f
      3bd7d93d
    • Kirk Shoop's avatar
      move pushmi into folly namespace · b5df374b
      Kirk Shoop authored
      Summary:
      put pushmi inside the folly namespace.
      
      NOTE: we discussed in the team and decided that we preferred to have a sub-namespace for pushmi
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10455165
      
      fbshipit-source-id: d0131d96172a14746971e2de7dbac7bb10604229
      b5df374b
    • Jeroen Vaelen's avatar
      fix typo in gen docs · eb20fbbe
      Jeroen Vaelen authored
      Reviewed By: ddrcoder
      
      Differential Revision: D10461414
      
      fbshipit-source-id: 75c6ddc7979ade91917cacb0b58038bbde51172a
      eb20fbbe
    • Jeroen Vaelen's avatar
      fix ifndef error path · c474a2d7
      Jeroen Vaelen authored
      Summary: The error was pointing to a file that does not exist.
      
      Reviewed By: ddrcoder, Orvid
      
      Differential Revision: D10461496
      
      fbshipit-source-id: 4a282db547ad0924da23ea1b7652cf702599acab
      c474a2d7
  5. 20 Oct, 2018 2 commits
  6. 19 Oct, 2018 9 commits
    • Doron Roberts-Kedes's avatar
      DeterministicSchedule: Make the data_ field of Deterministic Atomic come from... · 8cfc7d7f
      Doron Roberts-Kedes authored
      DeterministicSchedule: Make the data_ field of Deterministic Atomic come from a class template param.
      
      Summary: see title.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10467678
      
      fbshipit-source-id: b407cfa3c0cd1100b1f8f01ff8f2fee1f2a99ecb
      8cfc7d7f
    • Doron Roberts-Kedes's avatar
      DeterministicSchedule: Make data field of DeterministicAtomic private and rename to data_ · cda0ac8f
      Doron Roberts-Kedes authored
      Summary: See title.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10418223
      
      fbshipit-source-id: 262c92581ba6b36741f647e6cde624a4372436cf
      cda0ac8f
    • Kudo Chien's avatar
      Fix posix_memalign symbol not found with Android API 16 (#953) · c831d06b
      Kudo Chien authored
      Summary:
      According to this https://github.com/android-ndk/ndk/issues/647,
        posix_memalign may not exist on Android API 16.
        From Android NDK r17c, the API exists for Android API 17+.
      ```
          #if __ANDROID_API__ >= 17
          int posix_memalign(void** __memptr, size_t __alignment, size_t __size) __INTRODUCED_IN(17);
          #endif /* __ANDROID_API__ >= 17 */
      ```
        Change the code to use posix_memalign only after Android API 17+.
        This would also fix issue for OSS React Native to pack latest folly and building with clang.
        See: https://github.com/facebook/react-native/issues/20302 and https://github.com/facebook/react-native/issues/20342
      Pull Request resolved: https://github.com/facebook/folly/pull/953
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10469757
      
      Pulled By: Orvid
      
      fbshipit-source-id: c63838f3f6e723ef3de77187f39597a4063043db
      c831d06b
    • Gisle Dankel's avatar
      Fix memory usage issue · 4cabbe62
      Gisle Dankel authored
      Summary:
      I noticed during testing that jemalloc requests a lot more memory than is
      allocated by the application.
      This is particularly the case for allocations >4k. If the allocation is <2MB it
      asks for an extra 2MB region that is not used for allocated memory, and if the
      request is >2MB then an extra region of the same size is requested in the
      extent hook.
      Turns out the issue was that I didn't set *commit to true in the alloc hook,
      causing an interesting sequence of events to occur.
      Another issue is that when running out of space and falling back to the default
      hook, subsequent requests would increase in size forever. The solution here was
      to set the jemalloc retain grow limit.
      Finally, fixed a bug when reserving more than 4GB memory (size calculation was
      truncated to 32 bits).
      
      Reviewed By: interwq
      
      Differential Revision: D10316308
      
      fbshipit-source-id: af47438029e85c03bf51c8d132b88de551f493f1
      4cabbe62
    • Andrew Gallagher's avatar
      folly/memory/Malloc.h: include a few more JEMalloc macro definitions · 3c69262c
      Andrew Gallagher authored
      Summary:
      `folly/memory/Malloc.h` is generally used as a shim for the JEMalloc headers, providing
      weak declarations of JEMalloc functions so that they can be referenced in library code
      that may or may not be linked with JEMalloc at build/run time.
      
      This adds a few more macro definition stubs for when JEMalloc isn't available.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10395893
      
      fbshipit-source-id: 7b45714297acd85afd3b222687feeda491fcb46d
      3c69262c
    • Yedidya Feldblum's avatar
      Assignment for sorted-vector types from initializer-list · 03f51db9
      Yedidya Feldblum authored
      Summary: [Folly] Assignment operators for `sorted_vector_set` and `sorted_vector_map` from `std::initializer_list`.
      
      Reviewed By: nbronson
      
      Differential Revision: D10457311
      
      fbshipit-source-id: cd50963066ee89f2aa314b7cad089242fbc10d84
      03f51db9
    • Teng Qin's avatar
      Fix StaticTracepoint argument size type identification · dd8181f0
      Teng Qin authored
      Summary:
      We need to determine the size of the Tracepoint arguments in the Macro. The only exception that we can not simply take `sizeof` is arrays, where `sizeof` will return size of the array where we really want is size of a pointer. Before we specifically check this with `FOLLY_SDT_ISARRAY` which checks if `__builtin_classify_type` of the argument is 14. However in recent update of LLVM, some arrays will be reported with type 5 (pointer type). Originally we didn't add that because we thought if the type of the argument is already a pointer then just take a `sizeof` on it would still be correct. This Diff fixes the issue.
      
      LLVM change in question is https://reviews.llvm.org/rL333126
      
      Reviewed By: taewookoh
      
      Differential Revision: D10453657
      
      fbshipit-source-id: 154fdfc78fe6438cd66cf256203c8d174773c1a8
      dd8181f0
    • Yedidya Feldblum's avatar
      Tweak Futures Core ASCII art · 36bad07f
      Yedidya Feldblum authored
      Summary: (as title)
      
      Reviewed By: LeeHowes
      
      Differential Revision: D10453926
      
      fbshipit-source-id: f48d1fb672e3c65b7240c255c8ef7437a38a856c
      36bad07f
    • Yang Chi's avatar
      Support one more parameter in folly tracing macro · 7545a8f7
      Yang Chi authored
      Summary: support one more params into the folly tracing macro
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10451431
      
      fbshipit-source-id: 8ae7356b38b46c9c653a7d87c507048eba353414
      7545a8f7
  7. 18 Oct, 2018 12 commits
    • Darrin D'Mello's avatar
      Clean up AsyncSocketException interface to hide members that should be private · 2906dd94
      Darrin D'Mello authored
      Summary: Minor code cleanup.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10430502
      
      fbshipit-source-id: d4892baf695089458295550767b3eca1af20ca32
      2906dd94
    • Kirk Shoop's avatar
      change copyright headers and apply some clang format · 288e58f2
      Kirk Shoop authored
      Summary:
      changed the copyright headers to match folly
      ran clang format in places that it did not mess up too badly
      
      almost entirely whitespace changes
      
      Reviewed By: Orvid
      
      Differential Revision: D10450516
      
      fbshipit-source-id: dc00a3952ee63d9ceb218aacb8f5f55a7c171170
      288e58f2
    • Adam Simpkins's avatar
      fix the Windows build · a25bbf7c
      Adam Simpkins authored
      Summary:
      It looks like I also broke the Windows build of folly in D10435249, since
      FollyCompilerMSVC.cmake referenced the `folly_deps` target, which is now not
      defined yet when `FollyCompilerMSVC.cmake` is included.
      
      This changes the code so that `FollyCompilerMSVC.cmake` simply updates
      `${FOLLY_LINK_LIBRARIES}`, which is used in a `target_link_libraries()` call
      in `folly-deps.cmake`.  (I'm slightly surprised that CMake was happy before
      with multiple separate `target_link_libraries()` calls for the `folly_deps`
      target.)
      
      Reviewed By: Orvid
      
      Differential Revision: D10445483
      
      fbshipit-source-id: 5277785bec3fd8527d01a098e130c945077703ee
      a25bbf7c
    • Orvid King's avatar
      Split targets and move them into the right places · 18b002f6
      Orvid King authored
      Summary:
      They were bugging me so I brought out my tools and hit things with a stick until they were in the right place.
      I then proceeded to hit them with more sticks until autodeps worked, due to a few references to experimental headers which aren't in GCC 5.
      
      Reviewed By: kirkshoop
      
      Differential Revision: D10443067
      
      fbshipit-source-id: 81b4a895c5ca06d22c74ede6cd2a474457df22ab
      18b002f6
    • Lewis Baker's avatar
      Replace AwaitWraper with new co_viaIfAsync operator · dea4f330
      Lewis Baker authored
      Summary:
      Refactored the `AwaitWrapper` class to expose its functionality as a new `co_viaIfAsync()` operator that returns a `ViaIfAsyncAwaitable<Awaitable>` type.
      
      The `folly::coro::Task` promise_type now delegates wrapping the awaited operations to the new `co_viaIfAsync()` operator. This allows SemiAwaitable types to customise how they are awaited from within a folly::coro::Task coroutine by providing an overload for `co_viaIfAsync()` rather than intrusively modifying the `folly::coro::Task` implementation.
      
      Reviewed By: andriigrynenko
      
      Differential Revision: D9983074
      
      fbshipit-source-id: 87d80001879ac7aa3be473339ba259229dafc262
      dea4f330
    • Maged Michael's avatar
      Disable ParkinkLot.WaitableMutexTest under TSAN · cce0bb0a
      Maged Michael authored
      Summary: Disable ParkinkLot.WaitableMutexTest under TSAN for now. It currently fails under TSAN due to the possibility of a mutex being unlocked by a different thread.
      
      Reviewed By: djwatson
      
      Differential Revision: D10446986
      
      fbshipit-source-id: 21ec53e27fffd566956f4e8ef1d3084765138b75
      cce0bb0a
    • Nathan Bronson's avatar
      use sized deallocation for overaligned-memory helpers · 2bc39ca1
      Nathan Bronson authored
      Summary:
      This diff makes the overaligned memory helpers in folly/Memory.h
      use the sized operator delete when it is available.  These helpers
      perform memory allocation and deallocation for the F14 hash table.
      Sized deallocation is much more CPU efficient.
      
      This diff also refactors the logic of allocateOverAligned and
      deallocateOverAligned, removing duplication of the compile-time machinery
      and making the alloc/dealloc pairings more clear.
      
      Reviewed By: yfeldblum, marksantaniello
      
      Differential Revision: D10411913
      
      fbshipit-source-id: ddd306619c28c8317fdebce8b24b18695ff16f5d
      2bc39ca1
    • Francois Visconte's avatar
      Fix a few inconsistencies in folly benchmarks · dbcba7de
      Francois Visconte authored
      Summary:
      Avoid printing to standard output in benchmark which poison output when using
      `-json_output` flag.
      
      Make SynchronizedBenchmark run benchmark only (like any other benchmarks out
      there)
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10405010
      
      fbshipit-source-id: b034123fcda9d8b8d6ba6967641305886cb12673
      dbcba7de
    • Adam Simpkins's avatar
      cmake: find threads before applying compiler settings · d949df1f
      Adam Simpkins authored
      Summary:
      In D10405960 I moved folly-deps.cmake to be processed after
      FollyCompilerMSVC.cmake.
      
      It turns out that this causes configuration to fail in confusing ways when
      compiling with clang.  CMake fails reporting that it cannot find pthread.h,
      but the real problem is just that clang does not like the `-std=gnu++14` flag
      that has been applied by FollyCompilerUnix.cmake.  CMake doesn't appear to
      have C++-only version of `CMAKE_REQUIRED_FLAGS`, so this `-std` flag was being
      used even when invoking clang in C-only mode.
      
      Moving the `find_package(Threads)` call avoids this issue.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10435249
      
      fbshipit-source-id: 214ec9bbef43679864f714dc39c1e4423081c09b
      d949df1f
    • Andrii Grynenko's avatar
      Implement tail call optimization · 7bcd14c5
      Andrii Grynenko authored
      Summary: This adds an optimization for cases where recursive .then() is used to implement a loop. Instead of creating a chain of Cores that fulfil each other, we steal a callback from previous core if possible.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10392101
      
      fbshipit-source-id: 008c644df7472f5e280b24a41c62ee7199954abc
      7bcd14c5
    • Kirk Shoop's avatar
      restructure pushmi for folly · 6fc4b643
      Kirk Shoop authored
      Summary:
      removed top level project matter
      removed old build structure
      removed single header
      removed nonious
      moved include files to root
      change include paths to work in folly
      add TARGETS files for tests and most examples
      commented out catch tests pending gtest migration
      added cpp libraries for core, executors and operators
      fixes for additional warnings that are enabled in folly
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10438543
      
      fbshipit-source-id: 73af41a2c70cba126e063c6a8cf4363dc7444fef
      6fc4b643
    • Yedidya Feldblum's avatar
      Cut DestructorGuard default ctor · e9ec6e17
      Yedidya Feldblum authored
      Summary:
      [Folly] Cut `DestructorGuard` default ctor. It does not actually need one, but its presence can hurt.
      
      ```lang=c++
      void callback() {
        // compiles, which can hurt:
        DestructorGuard(delayed);
      
        // intended:
        DestructorGuard guard(delayed);
      }
      ```
      
      Reviewed By: lbrandy
      
      Differential Revision: D10413329
      
      fbshipit-source-id: f84eb0de0290cb09f7ac358044c2ef2d71dd8cea
      e9ec6e17
  8. 17 Oct, 2018 3 commits
    • Eric Niebler's avatar
      exclude folly/experimental/pushmi from the OSS builds for now · 9d03fa29
      Eric Niebler authored
      Summary: folly/experimental/pushmi isn't ready to build in the OSS environment yet, so exclude it.
      
      Reviewed By: Orvid
      
      Differential Revision: D10428301
      
      fbshipit-source-id: d6f033894cc060b560697f6bfa1d1f78102568d3
      9d03fa29
    • Uddipta Maity's avatar
      Adding support for IOBuf coalesce with certain headroom and tailroom · b8860675
      Uddipta Maity authored
      Summary:
      We need this in wormhole, as the capacity of the IOBuf may be very large, but,
      the data length is much smaller. Current implementation of coalesce() allocates
      large amount of memory unnecessarily.
      Adding methods to be able to set headroom and tailroom during coalesce.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10386802
      
      fbshipit-source-id: a0d787f41ed195eef409b942aaad583fc22692a3
      b8860675
    • Teng Qin's avatar
      Ensure FOLLY_SDT's Semaphore is in an allocated section · afd02e08
      Teng Qin authored
      Summary:
      Currently `FOLLY_SDT`'s Semaphore is just an global variable at where it was defined. Since it's initialized to 0 it will be put into the `.bss` section. It works fine currently, especially for Executable binaries, because tools, in particular BCC, will be writing to the virtual address directly.
      
      However, recent patches to Linux Kernel supports handling Semaphore (reference counter) natively along with the uprobe event, and it requires the Semaphore address to be allocated in the binary file so Kernel can find correct VMA for the address, especially for Shared Object binaries.
      
      This Diff makes `FOLLY_SDT_DEFINE_SEMAPHORE` to put the Semaphore into a `PROGBITS` section `.probes` that is writeable and allocated. This is a practice compatible with SystemTap's USDT implementation, where the Semaphores also reside in the `.probes` section, as can be found in CPython, libc, MySQL, PostgresSQL, and many applications already.
      
      Reviewed By: yfeldblum
      
      Differential Revision: D10319732
      
      fbshipit-source-id: 67ac0e55cc10cf1425a754d88cae0165b89ee993
      afd02e08