- 13 Nov, 2018 3 commits
-
-
Orvid King authored
Summary: Shift the tests as well. (Note: this ignores all push blocking failures!) Reviewed By: yfeldblum Differential Revision: D12981653 fbshipit-source-id: 0fda732df3882218746c173c885bff06b86abbac
-
Orvid King authored
Summary: The end. (Note: this ignores all push blocking failures!) Reviewed By: yfeldblum Differential Revision: D12878966 fbshipit-source-id: 23cf64b9f66560ddeb87631f5ab955334944ea55
-
Orvid King authored
Summary: Do it. Reviewed By: yfeldblum Differential Revision: D12988464 fbshipit-source-id: b5dd907f24f9064ea7c7e417e0616120339eb452
-
- 12 Nov, 2018 12 commits
-
-
Orvid King authored
Summary: Convert the tests as well Reviewed By: yfeldblum Differential Revision: D12981682 fbshipit-source-id: b07567802c4ddba0e0d1fbab7ea021b9ea948c42
-
Orvid King authored
Summary: Port more things over. Reviewed By: yfeldblum Differential Revision: D12989142 fbshipit-source-id: 6066978e42080748658cbe6ff94034037af2c656
-
Orvid King authored
Summary: More! Reviewed By: yfeldblum Differential Revision: D12818656 fbshipit-source-id: acb269258524ae22bf8761407713b89cf3d57a3a
-
Orvid King authored
Summary: More things. Reviewed By: yfeldblum Differential Revision: D12818556 fbshipit-source-id: 8e839489eb92a3ec3f0ac391c157ad3de42d596b
-
Orvid King authored
Summary: Just keep porting, just keep porting. Reviewed By: yfeldblum Differential Revision: D12818498 fbshipit-source-id: 48d404ed17caa79c241e2facc1a3d93715ce02cb
-
Orvid King authored
Summary: This is a big one, but adds support for NetworkSocket to AsyncSocket itself. Reviewed By: yfeldblum Differential Revision: D12818493 fbshipit-source-id: d7b73f356414b006f4fc6b1c380a8fa1c32b9a46
-
Orvid King authored
Summary: More support infrastructure. Reviewed By: yfeldblum Differential Revision: D12818441 fbshipit-source-id: b6d3a276ea332eccf8c6f43484fd25ec543bcc08
-
Orvid King authored
Summary: More support means more diffs, as many small ones as possible. Reviewed By: yfeldblum Differential Revision: D12818383 fbshipit-source-id: be364e01d8d6d7b7419a2fc870c93dafcba5d2b1
-
Orvid King authored
Summary: More places supporting NetworkSocket. Reviewed By: yfeldblum Differential Revision: D12818369 fbshipit-source-id: 6ee0ce2dde3283ea7fd8f657329dc55c78c90714
-
Kirk Shoop authored
Summary: discovered that trailing single-line comment token will force clang-format to keep a new-line. used this and clang format to get some of the files clang-format clean while still being more-or-less readable Reviewed By: yfeldblum Differential Revision: D13016291 fbshipit-source-id: 0c3428e52f3366d9d90b32a551d8853d163b8298
-
Kirk Shoop authored
Summary: used the wrong Concept to constrain the receiver CTAD for a value function. Reviewed By: yfeldblum Differential Revision: D13027571 fbshipit-source-id: 5478afbb10c5145960cc6107c173da2bf241b9bc
-
Matt Glazar authored
Summary: When the PCHECK for read() in Random::secureRandom fails, the message is often misleading. In the following case, bytesRead != size caused the assertion failure. Unfortunately, the message includes an unrelated error message ("No such file or directory"), which can throw people off: F1031 13:15:26.997059 270573 Random.cpp:69] Check failed: bytesRead >= 0 && size_t(bytesRead) == size : No such file or directory [2] Improve the message by splitting the PCHECK into a PCHECK (for the read() error) and a CHECK_EQ (for the logic error): F1108 17:33:31.771008 3185333 Random.cpp:70] Check failed: size_t(bytesRead) == size (112960 vs. 1048576) Reviewed By: yfeldblum, simpkins Differential Revision: D12856276 fbshipit-source-id: fe9067972db805a54f2cc290aab11bac425601ef
-
- 11 Nov, 2018 2 commits
-
-
Orvid King authored
Summary: As per https://github.com/facebook/folly/issues/961, it appears that Apple Clang takes issue with modifying const values in the constructor within a constexpr context. Reviewed By: yfeldblum Differential Revision: D13005049 fbshipit-source-id: b0c9efcb6c5c4667028a7e0948e2fac53afdb1d2
-
Orvid King authored
Summary: I missed a use of file descriptors in the last diff to clean up this test. Reviewed By: yfeldblum Differential Revision: D12990054 fbshipit-source-id: 433f5b624eaa5b4fb8b757ba0b503354d5da0623
-
- 09 Nov, 2018 5 commits
-
-
Andrii Grynenko authored
Summary: The lambda that gets the ctx moved in can be created before the via call. (Note: this ignores all push blocking failures!) Reviewed By: spalamarchuk Differential Revision: D13009656 fbshipit-source-id: 1c89905e544adc829124277465c32958a3489845
-
Yunus Rahbar authored
Reviewed By: simpkins Differential Revision: D12990230 fbshipit-source-id: 58d82299a8fe6aed75115008fe5dfb0f46d847c6
-
Andrii Grynenko authored
Summary: This makes it work for SemiFutures with deferred work. Reviewed By: yfeldblum Differential Revision: D12982589 fbshipit-source-id: 9dcd130c72e8df67e8b4773b228041f96da06b10
-
Chad Austin authored
Summary: dschatzberg and I used `folly::CachelinePadded` when `alignas(folly::hardware_destructive_interference_size)` would have sufficed. Add a comment clarifying when CachelinePadded is appropriate. Reviewed By: yfeldblum Differential Revision: D12970571 fbshipit-source-id: 7d9193358a7b1aec78c95b715641396474eaebcf
-
Dan Shiovitz authored
Summary: Seems reasonable to overload IOBufHash/Compare to support pointers, since they already take unique_ptrs. Reviewed By: yfeldblum Differential Revision: D12963089 fbshipit-source-id: 85124939cef7a18bfd02aeff392732fb93691903
-
- 08 Nov, 2018 5 commits
-
-
Andrii Grynenko authored
Summary: We want to have a guarantee that if f1() was run before f2(), then all writes done by f1() are also observable by f2(). Reviewed By: yfeldblum, davidtgoldblatt Differential Revision: D12982731 fbshipit-source-id: 2170e977a879d27d2daf1b5307441594e6aae00b
-
Shiva Shankar P authored
Summary: In most cases, it would be incorrect to discard the guard immediately after its creation. Reviewed By: yfeldblum Differential Revision: D12911100 fbshipit-source-id: cb11b01e2d246a5d0b6bb0031968551796e25abf
-
Andrii Grynenko authored
Reviewed By: William-J-Earl Differential Revision: D12982874 fbshipit-source-id: cc8d3a03896386f03df1c6720be312b2700e8fb3
-
Giuseppe Ottaviano authored
Reviewed By: nbronson Differential Revision: D12973004 fbshipit-source-id: 46de0c9ef6760a412fd2753595480ecd7e0be678
-
Orvid King authored
Summary: Port it away from raw file descriptors. Reviewed By: yfeldblum Differential Revision: D12908626 fbshipit-source-id: 2448c2bfb226dba9de4baa77439c6644b09284a4
-
- 07 Nov, 2018 3 commits
-
-
Alex Guzman authored
Summary: As it says on tin Reviewed By: ngoyal Differential Revision: D12933389 fbshipit-source-id: 6a0dcfb6aa7ae672dcd8f355bdf88a8dfe930d02
-
Doron Roberts-Kedes authored
Summary: The shutdown_race test tries to make use of uniformSubset distribution to achieve an ordering of shutdown/wait/post in at least 1 of 1000 runs. This is unnecessary to test the desired behavior of LifoSem under the possible orderings of shutdown/wait/post. Making matters worse, the test relies on the existence of a step size for uniformSubset that will a) schedule the child thread between shutdown and post in the parent thread, and b) continue to schedule only the child thread until after it calls wait. There are seeds for which this fails when new calls to beforeSharedAccess are added inside DeterministicSchedule. Reviewed By: yfeldblum Differential Revision: D12925523 fbshipit-source-id: bf3061ecc8ebf3e8c19ca6ca337dd6c45eab03b1
-
Georgios Bitzes authored
Summary: When folly is used as a submodule, CMAKE_SOURCE_DIR will point to the top-level repository, resulting in set_source_files_properties not taking effect when compiling with ASan. Replacing CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR points cmake to the intended file. Pull Request resolved: https://github.com/facebook/folly/pull/960 Reviewed By: yfeldblum Differential Revision: D12943633 Pulled By: Orvid fbshipit-source-id: a73560c5578062282f38dc3ff6c7a3364fb6cf6e
-
- 06 Nov, 2018 1 commit
-
-
Adam Simpkins authored
Summary: Add a `Subprocess::Options::detach()` call. This causes the subprocess to be spawned in grandchild process that will be reparented to init. The intermediate child process exits immediately after spawning the grandchild, allowing the parent process to `wait()` on it and destroy its `Subprocess` object without leaving any zombie children. Reviewed By: yfeldblum Differential Revision: D10860274 fbshipit-source-id: ac27d77d0033e3c03e27dd3f758ab70fd2dd990f
-
- 05 Nov, 2018 3 commits
-
-
Igor Sugak authored
Summary: as titled Reviewed By: Orvid Differential Revision: D12922934 fbshipit-source-id: b283b905393d93fb41f18553f12ad33f335e1507
-
Chad Austin authored
Summary: The old implementation of folly::none inadvertently allowed disengaging an optional by writing `op = nullptr`. Disallow that and require `op = folly::none`. Reviewed By: yfeldblum Differential Revision: D12884724 fbshipit-source-id: b17bcf00b245069d8ea2d9bc3703b0fdcaa85c07
-
Igor Sugak authored
Summary: Folly used to be clang-format clean, now it not. Disable clang-format for the violating subdirectory. Reviewed By: Orvid Differential Revision: D12922931 fbshipit-source-id: 55dd9684a52b4471aadf18f27658509823f34db4
-
- 03 Nov, 2018 3 commits
-
-
Orvid King authored
Summary: As-per title. Reviewed By: yfeldblum Differential Revision: D12908262 fbshipit-source-id: 6a9723add4f19b262b7dae9e105f9967041e31e2
-
Nathan Bronson authored
Summary: F14 tables with a std::string key now support heterogeneous lookup by default (lookup and insert of StringPiece, std::string_view, ...). This diff removes the explicit transparent hasher and equality that used to be needed to get this behavior. folly/experimental/StringKeyedUnorderedSet and Map will be removed later, as they are unnecessary. Reviewed By: ot, luciang Differential Revision: D12905270 fbshipit-source-id: ecb990bb330866c089ba156f8be0a5b235c5574d
-
Nathan Bronson authored
Summary: This extends the unit tests for auto-transparent hash and equality to verify that they apply to fbstring. Reviewed By: froody Differential Revision: D12908619 fbshipit-source-id: cdff815be6cb8fda6695cf745b20181f81ee0dd9
-
- 02 Nov, 2018 3 commits
-
-
Nathan Bronson authored
Summary: Macro name should not use a name that might also be used outside folly. Reviewed By: yfeldblum Differential Revision: D12901055 fbshipit-source-id: a18bc33fdaabb339aa7539da12b5a82b95e282a7
-
Orvid King authored
Summary: The value of `ECONNREFUSED` is different on different platforms, so we can't hard-code the value. Reviewed By: yfeldblum Differential Revision: D12818063 fbshipit-source-id: 94242a042bef75b391d075a74837b538083d242d
-
Doron Roberts-Kedes authored
Summary: Using DeterministicAtomic without initializing a DeterministicSchedule doesn't offer determinism, and at the time of the last commit to this test, DeterministicAtomics did not even have atomic operations without a DeterministicSchedule. Initializing a DeterministicSchedule for these tests adds determinism and atomicity to the current DeterministicAtomics. This is will be required once to support atomic history buffers in the future. Reviewed By: davidtgoldblatt Differential Revision: D10478718 fbshipit-source-id: f03629ab8683c05eff41eb4886d23d00d42615e8
-