1. 30 Apr, 2024 3 commits
    • Guido Casati's avatar
      Remove PDCP Suspend from nrUE · 2b859cd7
      Guido Casati authored
      - according to clause 5.3.7.2 of 3GPP TS 38.331
        PDCP Suspend is not required during RRCReestablishment
      2b859cd7
    • Guido Casati's avatar
      Re-establish RLC for SRB1 only when receiving RRCReestablishmentRequest · f010058e
      Guido Casati authored
      - according to 5.3.7.4 of TS 38.331: 1> re-establish RLC for SRB1;
      - gNB:
      1) re-establish RLC for SRB1 in nr_rlc_update_id
      2) re-establish RLC for remaining RBs concurrently with RRCReconfiguration
      
      issue: gNB) in nr_rlc_update_id the gNB is re-establishing RLC for all
                  RBs at the same time when receiving RRCReestablishmentRequest
                  from UE
              UE) according to the specs, the UE is re-establishing RLC for
                  SRB1 with RRCReestablishmentRequest the other RBs are
                  re-established during RRCReconfiguration (in our case in
                  nr_rrc_ue_process_RadioBearerConfig) when receiving
                  reestablishRLC IE in rlc_BearerToAddModList
          RLC TX) this leads to RLC counters mismatch after re-establishment:
                  control PDUs discarded until max nb of retx is reached
                  and then UL failure occurs
      f010058e
    • Guido Casati's avatar
      Minor comments and logging · 99c4e547
      Guido Casati authored
      99c4e547
  2. 21 Apr, 2024 1 commit
  3. 19 Apr, 2024 1 commit
  4. 17 Apr, 2024 2 commits
  5. 16 Apr, 2024 1 commit
    • Guido Casati's avatar
      Fix PDCP re-establishment of SRB1 and SRB2 · 5610ce07
      Guido Casati authored
      - SRB1 shall be re-established at the time of RRCReestablishmentRequest
        according to 5.3.7.4 of 3GPP TS 38.331
      - SRB2 shall be re-established when creating srb-ToAddModList
        according to 5.3.5.6.3 of 3GPP TS 38.331
      5610ce07
  6. 09 Apr, 2024 2 commits
    • Robert Schmidt's avatar
      Merge branch 'integration_2024_w14' into 'develop' · 1244c9a2
      Robert Schmidt authored
      Integration `2024.w14`
      
      Closes #775 and #773
      
      See merge request oai/openairinterface5g!2663
      
      * !2411 Simple and generic trx_write support of out of time order requests
      * !2532 moving decision on DCI format type to UE MAC
      * !2565 improvements in security of nrUE
      * !2656 remove stored G in UE DL, not needed and creating issues with DCI format 11/type0
      * !2658 Fix sleeping ue at synchro
      * !2649 NR SRS RRC assrtion removal
      * !2662 Avoid concurrent write while filling RX/CRC.indication
      * Remove obsolete "version" parameter from yaml files used on avra
      * !2664 Remove duplicated NAS message send, already done above
      * !2605 Improve performance polar encoder i.e., 3GPP 38.212 5.3.1.2 function
      * !2629 Msg2 and Msg3 at gNB: check allocation before committing to Msg2
      * !2657 replace transient malloc by stack allocation, add defense code on block size
      * !2631 chore(ci): some docker improvements
      * !2654 Pucch2 polar rx dynamic range fix
      * !2666 [E2 Agent] Fix E2 Setup Request for ASan
      * !2661 CI: iperf/iperf3 UDP analysis function fix → review in progress, review to be completed
      1244c9a2
    • Robert Schmidt's avatar
  7. 08 Apr, 2024 19 commits
  8. 05 Apr, 2024 6 commits
  9. 04 Apr, 2024 5 commits
    • Robert Schmidt's avatar
      Avoid concurrent write while filling RX/CRC.indication · 5951caa9
      Robert Schmidt authored
      We observe these asserts while running concurrent UL traffic on many
      UEs:
      
        Assertion (crc->rnti == rx->rnti) failed!
        In handle_nr_ulsch() ../../../openair2/NR_PHY_INTERFACE/NR_IF_Module.c:193
        mis-match between CRC RNTI 7221 and RX RNTI 35cf
      
      CRC and RX indication need to be pairwise for one UE, when here we have
      each for different UE. However, investigation seemed to indicate that
      both arrays for CRC and RX indication contained only one PDU; it seemed
      the RNTI changed while writing the CRC/RX.indication messages in
      nr_fill_indication().
      
      In this patch, we change the logic to mark a ULSCH free AFTER calling
      nr_fill_indication(). It is difficult to say if this makes the assertion
      disappear, but preliminary tests did not exhibit the same failure
      states.
      
      Closes #773
      5951caa9
    • Robert Schmidt's avatar
      Bugfix: make preamble_list an array · e6e25275
      Robert Schmidt authored
      - It is only a couple of bytes
      - It hid a bug: if two preambles, L1_nr_prach_procedures() overwrote the
        preamble of the first with the second one
      e6e25275
    • Robert Schmidt's avatar
      NRUE: print RA RNTI when receiving RAPID · 0f1f7687
      Robert Schmidt authored
      0f1f7687
    • Robert Schmidt's avatar
      increase response_window in multi-UE test · 08748008
      Robert Schmidt authored
      08748008
    • Robert Schmidt's avatar
      Do not reduce RACH.ind count in loop · 0e2c9e8e
      Robert Schmidt authored
      if we reduce, we will never do all rach indications. Go one-by-one
      instead.
      0e2c9e8e